IndexHelper: handle the output of an array of messages #2688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In some cases, IndexHelper will try to output an array of messages related to the same error. This PR takes that array and transforms it back into a string.
Verification Process
Normally, it'd make the index fail due to
[illegal_argument_exception] Limit of total fields [5000] in index [domain-post-1] has been exceeded
error if the user executeswp elasticpress index --setup --yes --show-errors
. With the code in the PR, the error is properly outputted, instead of silently failing.Changelog Entry
Fixed: Handle the output of an array of messages in sync processes.
Credits
Props @felipeelia