Fix issues with feature activation during install #2734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change fixes two issues:
The fix is that if no features are selected the user is asked to confirm, and if they do install is skipped with the same behaviour as following the Skip Install link. Additionally, when skipping installation any features that are activated automatically are deactivated so that skipping installation results in no active features.
This is fixed by deactivating any features that can be selected during install if they are not selected. This is necessary as certain features are activated by default before installation has even started.
Verification Process
Before each test clear all ElasticPress settings from the database for a fresh install. Each test should also be repeated for a multisite network activation.
Checklist:
Changelog Entry
Credits
Props @JakePT