-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync page refactor. #2738
Merged
Merged
Sync page refactor. #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Rewrites the sync page JavaScript as a
@wordpress/element
(React) application to address #2704 and #2706.Closes #2704, #2706.
Alternate Designs
I’ve taken the approach of building it as a React app, so I’ve basically also redone the markup and CSS. As part of that I’ve used a few standard WordPress components and also taken some liberties with the styling, to do things like making spacing more consistent. So basically in its current state there’s a bunch of visual changes compared to the current page that should be reviewed. Let me know if there’s things we’d prefer were more consistent with the existing page.
Note that with things like the stop button I’ve used the default ‘secondary’ style for buttons, because by sticking with the default styles for the standard button they can reflect the users’ admin color scheme (3rd and 4th pics). But let me know if we don’t care about that. I've similarly set the progress bar to match the admin color scheme.
Current page
New page
An idea I tried on a lark was setting the color scheme to ‘ElasticPress red’ as a way of branding the core components. Note this hasn't been implemented.
Verification Process
From the new version testing user stories:
Checklist:
Changelog Entry
Changed - Refactored Sync page JavaScript.
Fixed - Issues where the Sync page would not show the correct status of a sync.
Credits
Props @JakePT