Make last_processed_object_id be the last ID of fetched objects #2761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is an attempt to fix the problem outlined in #2755. When the last object of a batch is skipped, the last_processed_object_id isn't properly updated. That is easier to test when indexing only one document at a time (--no-bulk), as the only ID in the queue is the one that was skipped.
Closes #2755
Verification Process
Add a code like this to the codebase:
And run
wp elasticpress index --setup --no-bulk --show-errors --yes
Changelog Entry
Fixed: Sync process with skipped objects.
Credits
Props @juliecampbell @felipeelia