Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors properly when WP_DISABLE_FATAL_ERROR_HANDLER is false #2789

Merged
merged 2 commits into from
May 23, 2022

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented May 23, 2022

Description of the Change

In #2748 we've introduced an error handling. That only works when define( 'WP_DISABLE_FATAL_ERROR_HANDLER', true ); but that is not the default. This PR expands the error handling to also work with WP default behavior.

Changelog Entry

Added: New ep_sync_number_of_errors_stored filter.

Credits

@felipeelia @tott @JakePT

@felipeelia felipeelia added this to the 4.2.0 milestone May 23, 2022
@felipeelia felipeelia self-assigned this May 23, 2022
Copy link
Contributor

@tott tott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@felipeelia felipeelia merged commit 2369d91 into develop May 23, 2022
@felipeelia felipeelia deleted the fix/error-handling-and-wp branch May 23, 2022 14:10
felipeelia added a commit that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants