Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Horizontal scrolling in Quick Setup Screen #2937

Merged
merged 5 commits into from
Aug 24, 2022
Merged

Fix Horizontal scrolling in Quick Setup Screen #2937

merged 5 commits into from
Aug 24, 2022

Conversation

MARQAS
Copy link
Contributor

@MARQAS MARQAS commented Aug 10, 2022

Description of the Change

This PR fixes the Horizontal scrolling on the Quick Setup screen

Closes #2855

How to test the Change

  • Reset the setting by using wp elasticpress settings-reset
  • Go to Settings page
  • Observe that the Horizontal scroll is not appearing anymore

Changelog Entry

Fixed - Horizontal scroll in ElasticPress Quick Setup Screen

Credits

Props @MARQAS

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@MARQAS MARQAS added this to the 4.3.0 milestone Aug 10, 2022
@MARQAS MARQAS requested a review from JakePT August 10, 2022 18:49
JakePT
JakePT previously approved these changes Aug 24, 2022
@MARQAS MARQAS assigned felipeelia and unassigned JakePT and MARQAS Aug 24, 2022
@felipeelia
Copy link
Member

This will require a further adjustment @MARQAS. When on a multisite using WP 6.0.1, if I downgrade it to WP 6.0 this is how the screen looks like:

image

@MARQAS
Copy link
Contributor Author

MARQAS commented Aug 24, 2022

@felipeelia I added some styling for the update notice to match it with the other ones, can you please give it another look now?

@felipeelia felipeelia merged commit 9e31efc into develop Aug 24, 2022
@felipeelia felipeelia deleted the fix/2855 branch August 24, 2022 18:36
felipeelia added a commit that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Design issue on Quick Setup Screen
3 participants