Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Intermittent tests failures #2984

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Fix: Intermittent tests failures #2984

merged 5 commits into from
Sep 6, 2022

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Sep 5, 2022

Description of the Change

This PR fixes the following tests.

  1. testGetPointerData => The WP-Query in get_pointer_data_for_localize doesn't preserver the posts id. Passing the post__in to orderby fix the issue. Related Issue

  2. The wait is necessary. The problem is that test runs too quickly, and occasionally the category is not removed from the ES and because of this ES returns the deleted category. Related Issue When using protected content the admin may show outdated information under some scenarios #1415

Closes #2971

Changelog Entry

Fixed - Intermittent tests failures

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy changed the title Fix Tests Fix: Intermittent tests failures Sep 6, 2022
@burhandodhy burhandodhy marked this pull request as ready for review September 6, 2022 12:24
@burhandodhy burhandodhy added this to the 4.4.0 milestone Sep 6, 2022
@felipeelia felipeelia merged commit cde750f into develop Sep 6, 2022
@felipeelia felipeelia deleted the burhan/fix-2971 branch September 6, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Intermittent tests failures
2 participants