Add option to toggle term counter #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Sep 30, 2022
Comment on lines
949
to
951
| if ( ! empty( $settings['instant-results']['term_count'] ) ) { | ||
| $settings['instant-results']['term_count'] = (bool) $settings['instant-results']['term_count']; | ||
| } |
There was a problem hiding this comment.
@MARQAS couldn't this be simplified just calling
$settings['instant-results']['term_count'] = ! empty( $settings['instant-results']['term_count'] );
There was a problem hiding this comment.
@MARQAS @felipeelia Is this function required at all? None of the other Enabled/Disabled settings on the other features have anything like this. Also, sanitising as boolean isn't really worth it as the values are saved as '0' or '1' strings anyway, and the default value is '1' too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds an option to enable/disable the term count option in the Instant results widget.
Closes #2610
How to test the Change
Changelog Entry
Credits
Props @MARQAS
Checklist: