-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename wp-cli commands #3028
Merged
Merged
Rename wp-cli commands #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
approved these changes
Sep 30, 2022
felipeelia
requested changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MARQAS I've been thinking about this one and before we merge it there is a couple of changes we will need to make here:
- To avoid breaking someone else's code that can be extending our Command class, instead of a whole new class, let's make DeprecatedCommand a trait and include it in the regular Command class. This way we keep methods in a separate file but they will still be available to others.
- The
_deprecated_function
function does not output a warning to the user. Let's keep it there but also make a call toWP_CLI::warning
and add a notice to the command doc. Examples:
https://github.com/wp-cli/language-command/blob/8e25528afc90b709aaebba429752a86d12c500d1/src/Core_Language_Command.php#L334
https://github.com/wp-cli/scaffold-command/blob/4ae0066a64db0b93b4f923554cb8ab2b921e16c9/src/Scaffold_Command.php#L207
After 93e47a3, this still needs to be done (all in DeprecatedCommand.php):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is used to rename the WP-CLI commands as requested in #2981
Closes #2981
How to test the Change
Changelog Entry
Credits
Props @MARQAS
Checklist: