Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Add default update_term_meta_cache argument to get terms query #3060

Merged
merged 1 commit into from
Oct 17, 2022
Merged

perf: Add default update_term_meta_cache argument to get terms query #3060

merged 1 commit into from
Oct 17, 2022

Conversation

mae829
Copy link
Member

@mae829 mae829 commented Oct 14, 2022

Description of the Change

  • Call get_terms() with default update_term_meta_cache set to false to optimize queries, similar to post best practices.

Closes #3046

How to test the Change

Changelog Entry

Added - Default update_term_meta_cache parameter as false for get_terms() call in the ep_facet_search_get_terms_args filter for optimized query calls.

Credits

Props @mae829

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mae829 mae829 mentioned this pull request Oct 14, 2022
Closed
@felipeelia felipeelia added this to the 4.4.0 milestone Oct 17, 2022
@felipeelia felipeelia merged commit f15260f into 10up:develop Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Widget get_terms() optimization
2 participants
@mae829 @felipeelia