Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: delete-index --network-wide throws error when EP is not network activated #3172

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Fix: delete-index --network-wide throws error when EP is not network activated #3172

merged 1 commit into from
Dec 7, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes an issue where EP throws an error during the delete-index --network-wide when EP is not activated on network wide

Closes #3171

How to test the Change

  1. Activate EP only on Main Site
  2. Run wp elasticpress delete-index --network-wide --yes WPCLI command
  3. It should only delete the main site indexes

Changelog Entry

Fixed - CLI command delete-index --network-wide throws error when EP is not network activated

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia merged commit 40d6738 into develop Dec 7, 2022
@felipeelia felipeelia deleted the fix/3171 branch December 7, 2022 14:26
@felipeelia felipeelia added this to the 4.4.1 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.

BUG: CLI command delete-index --network-wide throws error
2 participants
@burhandodhy @felipeelia