Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: JS error on Status Report page #3187

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Fix: JS error on Status Report page #3187

merged 5 commits into from
Dec 12, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes an issue where the Status Report page returns the JS error when allow parameter information is empty and it return the array within array https://github.com/10up/ElasticPress/blob/4.4.0/includes/classes/StatusReport/ElasticPressIo.php#L62

Also it adds additional check that will check if the feature is not activate than don't add the information in report.

Closes #3179

How to test the Change

Changelog Entry

Fixed - JS error on Status Report page.

Credits

Props @burhandodhy @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.4.1 milestone Dec 12, 2022
@felipeelia felipeelia merged commit 27a1f69 into develop Dec 12, 2022
@felipeelia felipeelia deleted the fix/3179 branch December 12, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: JS error on "Status Report" page
2 participants