Rename Last Sync in Status Report #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Jan 4, 2023
There was a problem hiding this comment.
In addition to my comment here, any reason why you did not remove the start date from the collapsible as we've agreed during the sync, @MARQAS?
| $title = $sync_info['start_date_time']; | ||
| if ( false !== \ElasticPress\Utils\get_indexing_status() ) { | ||
| /* translators: last sync title */ | ||
| $title = sprintf( __( '%s ( In Progress )', 'elasticpress' ), $title ); |
There was a problem hiding this comment.
Suggested change
| $title = sprintf( __( '%s ( In Progress )', 'elasticpress' ), $title ); | |
| $title = sprintf( __( '%s (In Progress)', 'elasticpress' ), $title ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR will rename the Last Sync text in the sub-section of Last Sync present in the Status Report page
Closes #3208
How to test the Change
wp elasticpress settings-reset --yesChangelog Entry
Credits
Props @MARQAS @tomioflagos
Checklist: