Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap filter bool functions #3301

Merged
merged 13 commits into from
Feb 22, 2023
Merged

Swap filter bool functions #3301

merged 13 commits into from
Feb 22, 2023

Conversation

oscarssanchez
Copy link
Contributor

@oscarssanchez oscarssanchez commented Feb 7, 2023 •
edited
Loading

Description of the Change

Closes #3199

How to test the Change

Changelog Entry

Changed - Filter command flags using get_flag_value()

Credits

Props @oscarssanchez , @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@oscarssanchez oscarssanchez changed the title WIP: Swap filter bool functions Swap filter bool functions Feb 7, 2023
@felipeelia felipeelia added this to the 4.5.0 milestone Feb 22, 2023
@felipeelia felipeelia merged commit ceb1805 into develop Feb 22, 2023
@felipeelia felipeelia deleted the fix/cli-boolean-values branch February 22, 2023 17:55
@felipeelia felipeelia mentioned this pull request Feb 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

BUG: Evaluate other assoc_args as booleans
2 participants
@oscarssanchez @felipeelia