Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to autosuggest fetch config #3382

Merged
merged 8 commits into from
Apr 4, 2023
Merged

Conversation

tlovett1
Copy link
Member

@tlovett1 tlovett1 commented Mar 9, 2023

Description of the Change

Adds a simple filter to fetchConfig in the autosuggest JavaScript.

How to test the Change

Changelog Entry

Added - ep.Autosuggest.fethConfig filter to autosuggest JavaScript for filtering Elasticsearch fetch configuration.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@brandwaffle
Copy link
Contributor

@felipeelia there's a typo in the filter name we'll need to fix (feth vs fetch), then let's slot this for 5.0 and ensure we have any needed tests in place prior to a merge.

@felipeelia felipeelia added this to the 5.0.0 milestone Mar 9, 2023
@felipeelia felipeelia modified the milestones: 5.0.0, 4.5.1 Mar 29, 2023
@MARQAS MARQAS assigned felipeelia and unassigned MARQAS Apr 3, 2023
@felipeelia felipeelia merged commit 20124e5 into develop Apr 4, 2023
@felipeelia felipeelia deleted the filter-epas-request-args branch April 4, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants