Fix the output of put-mapping errors #3464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently, if the put-mapping operation returns an error, the message returned says
Mapping failed: Array
. This PR fixes that introducing a general function that gets an Elasticsearch response and returns the error reason in it (if any.)How to test the Change
Add the following snippet to your codebase and run
wp elasticpress sync --setup
,wp elasticpress put-mapping
, or sync via the UI:Changelog Entry
Credits
Props @felipeelia
Checklist: