Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the suggestion if the score is less than the threshold value. #3492

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR improves the Did You Mean experience by removing the suggestion if the suggested term score is lower than the threshold value.

Closes #

How to test the Change

Changelog Entry

Changed - Remove unwanted suggestions if the score is lower than threshold.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.6.0 milestone Jun 12, 2023
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
includes/classes/Indexable/Post/QueryIntegration.php Outdated Show resolved Hide resolved
tests/php/features/TestDidYouMean.php Outdated Show resolved Hide resolved
@felipeelia felipeelia merged commit 25de875 into develop Jun 12, 2023
@felipeelia felipeelia deleted the improve-unwanted-suggestions branch June 12, 2023 19:06
felipeelia added a commit that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants