Add ep_facet_special_slug_taxonomies filter #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Jul 17, 2023
oscarssanchez
changed the title
felipeelia
requested changes
Jul 25, 2023
There was a problem hiding this comment.
@oscarssanchez do you mind putting together a small test covering the new add_taxonomy_attributes method, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR introduces a new filter to account for the edge case from https://github.com/10up/ElasticPress/pull/3506/files#diff-64cabb18869a398887abf9cc35592a9636381971dedfc6e1ee1b3ada27188edfL175 and moves the code to the Woocommerce feature.
If we ever need to do something like this again, we can reuse this filter.
Closes #3467
How to test the Change
Changelog Entry
Credits
Props @oscarssanchez
Checklist: