Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Media Attachments from search #3539

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Remove Media Attachments from search #3539

merged 2 commits into from
Jul 19, 2023

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Jul 17, 2023 •
edited
Loading

Description of the Change

This PR adds the option to exclude the Document files from the search

Closes #3514

How to test the Change

  1. Enable the "Documents" feature
  2. Upload the PDF document
  3. Go to edit page and check "Exclude from search results" option
  4. Search the file name on frontend and see that EP doesn't return that file

Changelog Entry

Added - Remove Media Attachments from search

Credits

Props @burhandodhy @felipeelia and @gwhitehead

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy marked this pull request as ready for review July 17, 2023 12:28
@burhandodhy burhandodhy added this to the 4.7.0 milestone Jul 17, 2023
felipeelia
felipeelia reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. My only question is about the text displayed. Shouldn't that say "media" or something different?

Excludes this post from the results of your site's search form while ElasticPress is active.

@felipeelia felipeelia merged commit 860cad6 into develop Jul 19, 2023
@felipeelia felipeelia deleted the feature/3514 branch July 19, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia left review comments

Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Remove Media Attachments from search
2 participants
@burhandodhy @felipeelia