Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Features to declare settings as JSON #3655

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Update Features to declare settings as JSON #3655

merged 7 commits into from
Sep 27, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.0.0 milestone Sep 26, 2023
JakePT
JakePT requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@JakePT JakePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

@felipeelia felipeelia merged commit 3824626 into 5.0.0 Sep 27, 2023
9 checks passed
@felipeelia felipeelia deleted the feature/tw-19354069-json-settings branch September 27, 2023 16:39
@JakePT JakePT mentioned this pull request Oct 3, 2023
Merged
4 tasks
@mardelnet mardelnet mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakePT JakePT JakePT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeelia @JakePT