Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composer install throws error for PHP 8 #3683

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix composer install throws error for PHP 8 #3683

merged 2 commits into from
Oct 10, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes an issue where composer install throws an error on PHP 8 by downgrading the doctrine/instantiator to 1.5.0

Closes #

How to test the Change

Changelog Entry

Fixed - composer install throws an error for PHP 8

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.7.2 milestone Oct 5, 2023
@felipeelia felipeelia merged commit c6f5a7e into develop Oct 10, 2023
10 checks passed
@felipeelia felipeelia deleted the downgrade-doctrine/instantiator branch October 10, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@burhandodhy @felipeelia