Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: You passed a container to the second argument of root.render #3687

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes an issue where Instant Result throws a warning You passed a container to the second argument of root.render(...). You don't need to pass it again since you already passed it to create the root.

Closes #

How to test the Change

Changelog Entry

Fixed - Instant Results console warning

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.7.2 milestone Oct 6, 2023
@felipeelia felipeelia modified the milestones: 4.7.2, 5.0.0 Oct 10, 2023
@felipeelia felipeelia merged commit 5bad155 into develop Oct 17, 2023
9 of 10 checks passed
@felipeelia felipeelia deleted the fix/console-warning-for-instant-results branch October 17, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants