Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tear down WooCommerce functionalities when the plugin is not active #3688

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Tear down WooCommerce functionalities when the plugin is not active #3688

merged 2 commits into from
Oct 11, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #2865

How to test the Change

  1. Activate ElasticPress for the entire network
  2. Activate WooCommerce just on the first site
  3. Activate the WooCommerce EP feature
  4. Run wp cache flush and wp transient delete wc_attribute_taxonomies --url=<url_of_second_site>
  5. Run wp elasticpress sync --setup --yes --network-wide
  6. See the warning in the error log
  7. Apply the PR
  8. Do the same steps and see the warning is gone

Changelog Entry

Changed - WooCommerce-related hooks are now removed when switching to a site that does not have WC active

Credits

Props @felipeelia @MARQAS

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.0.0 milestone Oct 6, 2023
@felipeelia felipeelia linked an issue Oct 6, 2023 that may be closed by this pull request
BUG: Error during the index with Multisite + WooCommerce setup #2865
Closed
burhandodhy
burhandodhy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit ef84003 into 5.0.0 Oct 11, 2023
8 of 9 checks passed
@felipeelia felipeelia deleted the fix/issue-2865 branch October 11, 2023 13:43
@felipeelia felipeelia mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

BUG: Error during the index with Multisite + WooCommerce setup
2 participants
@felipeelia @burhandodhy