Add Date Filter #3700
Merged
Add Date Filter #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
felipeelia
reviewed
Oct 17, 2023
There was a problem hiding this comment.
@burhandodhy I gave it a quick look and overall it looks good, just added a few comments. Let's also ask @JakePT to give it a look.
JakePT
requested changes
Oct 18, 2023
|
|
||
| <?php if ( $this->display_custom_date ) : ?> | ||
| <li> | ||
| <a aria-label="Apply filter: <?php esc_html_e( 'Custom', 'elasticpress' ); ?>" href="#" rel="nofollow" class="ep-date-range-custom <?php echo $is_custom_date ? 'checked' : ''; ?>"> |
There was a problem hiding this comment.
I think this will need some changes for accessibility, only when the filter is not applied:
- Add
role="button" - Add an
aria-expandedattribute that changes when the date form is shown. - Change the aria-label to something like "Select date range".
When it is already applied it should just be a link and the label should read "Remove filter", like the checkbox filters.
burhandodhy
force-pushed
the
feature/3634
branch
from
3046fb9
to
bc50521
Compare
felipeelia
requested changes
Oct 22, 2023
There was a problem hiding this comment.
@burhandodhy I gave this a try and if I uncheck the "Display custom date option" and save, the block doesn't seem to work anymore. (I see a Cannot read properties of null (reading 'classList') error in the console.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a new Filter block that is the "Date Filter"
Closes #3634
How to test the Change
Changelog Entry
Credits
Props @burhandodhy
Checklist: