Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosuggest - Google Analytics and EP.io #3835

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Autosuggest - Google Analytics and EP.io #3835

merged 2 commits into from
Feb 15, 2024

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR fixes 2 different problems:

  1. ElasticPress.io customers should not see the Autosuggest Endpoint URL field
  2. If the website is adding a Google Tag via Tag Manager, the gtag function will not be available. This PR creates the method, using the same idea shared in this article.

Closes #3833

How to test the Change

Changelog Entry

Fixed - Autosuggest - Hide the Autosuggest Endpoint URL field for EP.io users
Fixed - Autosuggest - Google Analytics integration gtag call

Credits

Props @felipeelia, @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.1.0 milestone Feb 9, 2024
@felipeelia felipeelia merged commit 114be13 into develop Feb 15, 2024
10 of 14 checks passed
@felipeelia felipeelia deleted the fix/autosuggest-epio-ga branch February 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakePT JakePT JakePT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

BUG: Google Analytics events not firing before navigation
2 participants
@felipeelia @JakePT