Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the mapping exists before trying to change it #3846

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3823

How to test the Change

Changelog Entry

Fixed - [Synonyms] Fatal error when saving synonyms if an index does not exist.

Credits

Props @felipeelia, @MARQAS, @randallhedglin, @bispldeveloper

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.1.0 milestone Feb 27, 2024
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit 64fb22c into develop Feb 28, 2024
14 of 16 checks passed
@felipeelia felipeelia deleted the fix/issue-3823 branch February 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: 500 error upon saving new synonyms
2 participants