Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open instant results modal if an autosuggest suggestion is selected. #3864

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Mar 17, 2024

…cted.

Description of the Change

Prevents the Instant Results modal from opening if an Autosuggest suggestion is highlighted, allowing the user to open the suggestion with the Enter key without a conflict.

Closes #3824

How to test the Change

  1. Activate Instant Results and Autosuggest.
  2. Enter a search query so that suggestions appear.
  3. Navigate to a suggestion with the arrow keys and press Enter.
  4. You should be taken to the suggestion and Instant Results should not launch,

Changelog Entry

Fixed - An issue where pressing Enter to select an Autosuggest suggestion would instead open Instant Results.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.1.0 milestone Mar 18, 2024
@felipeelia felipeelia merged commit c014edc into develop Mar 18, 2024
21 of 22 checks passed
@felipeelia felipeelia deleted the fix/3824 branch March 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Keyboard navigation is not working for Autosuggest when both Autosuggest and Instant Results are enabled
2 participants