Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .gitignore when checking the changed files #13

Closed
wants to merge 2 commits into from

Conversation

selul
Copy link

@selul selul commented Jan 7, 2020

Description of the Change

When using a workflow where some files are ignored on git but they are present on wordpress.org SVN, it's impossible to update the readme or any assets as the svn sees the git ignored files as changed.

Verification Process

I've tested on one of our projects, here you have the run log of the action.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#12

@jeffpaul
Copy link
Member

Thanks again for the PR @selul, I've milestoned this for our next release and will get back to you with any questions after this gets through review.

@helen helen removed this from the 1.4.1 milestone Mar 9, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Aug 20, 2021
@helen helen removed this from the 2.0.0 milestone Aug 24, 2021
@helen
Copy link
Collaborator

helen commented Aug 24, 2021

See #12 for further thoughts on overall approach, I am not opposed to config although I still have a sense that going by .gitignore is not quite right.

@jeffpaul jeffpaul added this to the Future Release milestone Jan 5, 2022
@jeffpaul
Copy link
Member

jeffpaul commented Jan 9, 2023

@10up/open-source-practice anyone feel strongly able moving this PR along or is this something we might consider closing as not the best approach for this?

@dkotter
Copy link
Collaborator

dkotter commented Jan 9, 2023

So this PR mentions issue #12, which has since been closed out due to PR #32. I can't quite tell if the changes made there fix the same thing mentioned here, but seems similar. I'd suggest we close this out for now and if there are still unresolved things, a new issue can be opened to track those.

@jeffpaul jeffpaul removed this from the Future Release milestone Jan 9, 2023
@jeffpaul jeffpaul closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants