Adjust propset for images and set mime type for gif/SVG images #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of 10up/action-wordpress-plugin-deploy#82 to also bring support for gif and svg types.
dinhtungdu
reviewed
Jul 4, 2022
There was a problem hiding this comment.
@ocean90 Thanks so much for PR and I'm so sorry for this late review!
Can you fix the glob issue as 10up/action-wordpress-plugin-deploy#99 does? svn doesn't expand the wildcard inside quotes:
Test command output
~/workspace/test/command-palette
130 % svn propset svn:mime-type "image/png" $SVN_DIR/assets/*.png
property 'svn:mime-type' set on 'assets/banner-1544x500.png'
property 'svn:mime-type' set on 'assets/banner-772x250.png'
property 'svn:mime-type' set on 'assets/icon-128x128.png'
property 'svn:mime-type' set on 'assets/icon-256x256.png'
property 'svn:mime-type' set on 'assets/screenshot-1.png'
property 'svn:mime-type' set on 'assets/screenshot-2.png'
~/workspace/test/command-palette
% svn propset svn:mime-type "image/png" "$SVN_DIR/assets/*.png"
'assets/*.png' is not under version control
svn: E155010: The node '/Users/tenup/workspace/test/command-palette/assets/*.png' was not found.
~/workspace/test/command-palette
1 % svn --version
svn, version 1.14.1 (r1886195)
compiled Sep 19 2021, 11:27:17 on arm-apple-darwin20.5.0
Props @diddledani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is a port of 10up/action-wordpress-plugin-deploy#82 to also bring support for gif and SVG images.
Closes #31.
Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
Checklist:
Changelog Entry
Added: Add correct mime type for gif and SVG images.
Credits
Props
@Lewiscowles1986,@iamdharmesh,@ocean90