Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for ZIP #43

Merged
merged 1 commit into from
May 27, 2020
Merged

Fix path for ZIP #43

merged 1 commit into from
May 27, 2020

Conversation

helen
Copy link
Collaborator

@helen helen commented May 27, 2020

Description of the Change

Because of the Docker mapping the path $GITHUB_WORKSPACE in Bash is not the same as the path of github.workspace in the webhook payload. So, let's use the latter instead of trying to be smart with the path. If we want to avoid being so direct with the reference, I think we would need to upload and download the ZIP as an artifact which seems like a lot of unnecessary work to me. cc @shivapoudel

Alternate Designs

See above.

Benefits

Actually make #42 and #37 work.

Possible Drawbacks

More config to potentially break in individual workflow files themselves, I guess?

Verification Process

Ran a stripped down version of this in a test repo.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#4

Changelog Entry

@helen helen merged commit 8624d15 into develop May 27, 2020
@helen helen deleted the fix/generate-zip branch May 27, 2020 03:35
@helen
Copy link
Collaborator Author

helen commented May 27, 2020

@shivapoudel Works now :)

@shivapoudel
Copy link
Contributor

@helen Thanks! That works great!

Additionally do remove this bit of code

outputs:
zip_path:
description: 'Zip file path'

@helen helen added this to the 1.5.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants