Labels feature #181
Merged
Labels feature #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tott
reviewed
Dec 18, 2020
includes/api/class-bc-cms-api.php
Outdated
| */ | ||
| public function get_account_labels() { | ||
| $result = $this->send_request( esc_url_raw( self::CMS_BASE_URL . $this->get_account_id() . '/labels/' ), 'GET' ); | ||
| return $result['labels']; |
There was a problem hiding this comment.
Seems dangerous without validation
…to feature/brightcove-labels
…to feature/brightcove-labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds a new feature called labels. It adds a submenu of the brightcove settings called "Labels". Basic usage is described below.
First we need to add new labels via the Labels submenu:
After this we can add the labels to videos by editing the video:
Here we can add as many labels to a video as needed. The feature will automatically search for existing labels and attempt to autocomplete:
Once these labels are associated with a video, we can filter by label as well:
Alternate Designs
Benefits
Adds support for labels in the plugin
Possible Drawbacks
Verification Process
Checklist:
Applicable Issues
Changelog Entry