Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with WP 6.2+ JS #342

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Compatibility with WP 6.2+ JS #342

merged 4 commits into from
Oct 10, 2023

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Sep 11, 2023 •
edited
Loading

Description of the Change

Closes #334
Closes #335
Closes #336

How to test the Change

Changelog Entry

Changed - Use wp.blockEditor.BlockControls if available

Credits

Props @felipeelia and @oscarssanchez

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 2.8.3 milestone Sep 11, 2023
@felipeelia felipeelia changed the title Use wp.blockEditor.BlockControls if available Compatibility with WP 6.2+ JS Sep 11, 2023
felipeelia
felipeelia commented Sep 11, 2023
View reviewed changes
assets/js/src/block.js Outdated Show resolved Hide resolved
JakePT
JakePT requested changes Sep 12, 2023
View reviewed changes
assets/js/src/block.js Outdated Show resolved Hide resolved
@felipeelia felipeelia merged commit b4855ff into develop Oct 10, 2023
@felipeelia felipeelia deleted the fix/issue-334 branch October 10, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakePT JakePT JakePT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.4
2 participants
@felipeelia @JakePT