Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger fetch:apiError if request is aborted #368

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

burhandodhy
Copy link
Collaborator

Description of the Change

This PR fixes an issue where the plugin displays the error message when the new filter is applied before the previous ajax is completed. 

Closes #355

How to test the Change

  1. Go to the video page.
  2. Apply the filters in such a way that you apply the second filter before the ajax request for the first filter is completed.
  3. Unselect all the filters.

Changelog Entry

Fixed - Display error message when the previous request is aborted

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy merged commit 695a3a1 into develop Jan 29, 2024
11 checks passed
@burhandodhy burhandodhy deleted the fix/355 branch January 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message remains on the screen even after the new AJAX call runs successfully.
2 participants