Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WP minimum version to 5.2 #20

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Update WP minimum version to 5.2 #20

merged 5 commits into from
Jun 10, 2022

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Jun 3, 2022 •
edited
Loading

Description of the Change

As we are using WP 5.2 version as a minimum version in @10up/cypress-wp-utils and our other repos, This PR is to update the minimum WP version to 5.2.

Apart from updates to 5.2, this PR contains below minor changes.

  • Fix createPost command example in README.MD
  • Made test run on push to develop and trunk in cypress.yml
  • Update actions/checkout to v3

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Changed: WP minimum version to 5.2

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Jun 3, 2022
@iamdharmesh iamdharmesh marked this pull request as ready for review June 9, 2022 09:18
@iamdharmesh iamdharmesh requested a review from cadic June 9, 2022 09:19
cadic
cadic approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @iamdharmesh!

@cadic cadic merged commit 93837ad into develop Jun 10, 2022
@cadic cadic deleted the upkeep/5.2 branch June 10, 2022 05:56
@dkotter dkotter added this to the 0.1.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadic cadic cadic approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
None yet
Projects
Open Source Practice
Archived in project
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@iamdharmesh @cadic @dkotter