Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set chromeWebSecurity config value to false by default #34

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Aug 23, 2023

Description of the Change

Due to changes in WordPress 6.3 that tries to load the block editor in an iframe by default, setting chromeWebSecurity to false helps avoid errors interacting with that iframe.

In addition, tests were failing due to some changes needed for the latest version of wp-env. This has been duplicated from #35 just so tests will pass.

Alternate Designs

None

Possible Drawbacks

I'm not aware of any issues with setting this to false

Verification Process

If desired, check out the branch and run the setup process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - Set chromeWebSecurity to false in our Cypress config

Credits

Props @dkotter

@dkotter dkotter requested a review from a team as a code owner August 23, 2023 20:47
@dkotter dkotter self-assigned this Aug 23, 2023
@dkotter dkotter requested review from iamdharmesh and removed request for a team August 23, 2023 20:47
@dkotter dkotter added this to the 0.1.0 milestone Aug 23, 2023
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dkotter dkotter merged commit 79089fa into develop Aug 25, 2023
@dkotter dkotter deleted the feature/add-chrome-web-security-config branch August 25, 2023 14:43
@dkotter dkotter modified the milestones: 0.1.0, 0.2.0 Aug 25, 2023
@dkotter dkotter modified the milestones: 0.2.0, 0.1.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants