Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete existing wp-env config if latest version #8

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Delete existing wp-env config if latest version #8

merged 1 commit into from
Mar 2, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Mar 2, 2022

Description of the Change

set-core-veresion.js script will delete existing .wp-env.override.json if 'latest' WordPress core version is specified.

Closes #5

Verification Process

  1. Install npx github:10up/cypress-wp-setup
  2. Set core version other than latest (f.e. ./tests/bin/set-core-version.js WordPress/WordPress#5.9)
  3. Set core version to latest: ./tests/bin/set-core-version.js latest
  4. .wp-env.override.json expected to be deleted

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - Setting core version to latest after if other version was set before

Credits

Props @cadic

@cadic cadic added this to the 0.2.0 milestone Mar 2, 2022
@cadic cadic self-assigned this Mar 2, 2022
@cadic cadic merged commit f3d3de5 into develop Mar 2, 2022
@cadic cadic deleted the fix/5 branch March 2, 2022 15:17
@dkotter dkotter modified the milestones: 0.2.0, 0.1.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set core version latest does nothing
2 participants