Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search in Pull UI incorrectly sanitizes #230

Closed
ChaosExAnima opened this issue Oct 10, 2018 · 3 comments
Closed

Search in Pull UI incorrectly sanitizes #230

ChaosExAnima opened this issue Oct 10, 2018 · 3 comments
Milestone
1.3.2

Comments

@ChaosExAnima
Copy link
Contributor

In the Distributor Pull UI, searching is returning incorrect results for queries with spaces or other formatting.

Reviewing the code, and it seems that sanitize_key was used to sanitize search text, which strips out all text and formatting. Suggest replacing that with rawurlencode or sanitize_text_field.
ChaosExAnima pushed a commit that referenced this issue Oct 10, 2018
Fixes #230
8c738d9
@robbiet480
Copy link
Contributor

robbiet480 commented Oct 10, 2018 •
edited
Loading

Funny, I was just planning to report this as well, good timing @ChaosExAnima :)

@ChaosExAnima ChaosExAnima mentioned this issue Oct 10, 2018
Merged
@ChaosExAnima
Copy link
Contributor Author

I try! PR is now up whenever you're ready, @helen. Thanks!

@helen helen added this to the 1.3.2 milestone Oct 11, 2018
@helen
Copy link
Contributor

helen commented Oct 11, 2018

For history, this was introduced in 5600b2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.2
Development

No branches or pull requests
3 participants
@robbiet480 @helen @ChaosExAnima