Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt_push_post_args filters are defined inconsistently. #370

Closed
gthayer opened this issue Apr 24, 2019 · 0 comments · Fixed by #371
Closed

dt_push_post_args filters are defined inconsistently. #370

gthayer opened this issue Apr 24, 2019 · 0 comments · Fixed by #371
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@gthayer
Copy link

gthayer commented Apr 24, 2019

The filter dt_push_post_args is used inconsistently, where External Connections are using 3 variables with the 3rd being the class object, while Internal Connections have 4 variables with the 4th being the class object.

I believe we should add the missing $args value in the external connections call, and set the class object as the 4th value to match the internal connections call.

These should be consistant because filters looking for 4 values will get Uncaught ArgumentCountError: Too few arguments errors.

PR incoming...

@jeffpaul jeffpaul added the type:bug Something isn't working. label Apr 24, 2019
@jeffpaul jeffpaul added this to the 1.5.0 milestone Apr 24, 2019
@jeffpaul jeffpaul modified the milestones: 1.5.0, Future Release Jun 6, 2019
@helen helen modified the milestones: Future Release, 1.5.0 Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants