Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dt_push_post_args usage #371

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Unify dt_push_post_args usage #371

merged 2 commits into from
Jul 17, 2019

Conversation

gthayer
Copy link

@gthayer gthayer commented Apr 24, 2019

Unified the usage of dt_push_post_args, where External Connections are using 3 variables with the 3rd being the class object, while Internal Connections have 4 variables with the 4th being the class object. Added the $args value in the 3rd slot and pushed the class object to the 4th value.

Fixes: #370

@gthayer gthayer changed the title Fix/dt push post args Unify dt_push_post_args usage Apr 24, 2019
@gthayer gthayer added the type:bug Something isn't working. label Apr 24, 2019
@jeffpaul jeffpaul added this to the 1.5.0 milestone Apr 24, 2019
@jeffpaul
Copy link
Member

jeffpaul commented Jun 5, 2019

@gthayer it looks like the build failed on these changes, mind giving those a review to try and ensure this build passes?

@jeffpaul jeffpaul added the needs:feedback This requires reporter feedback to better understand the request. label Jun 5, 2019
@jeffpaul jeffpaul modified the milestones: 1.5.0, Future Release Jun 5, 2019
@gthayer
Copy link
Author

gthayer commented Jun 5, 2019

@jeffpaul - I'm not familiar with the CI setup here, but it looks like there was a timeout error on the build:

Nesk\Rialto\Exceptions\Node\FatalException: waiting for selector ".media-modal-content" failed: timeout 90000ms exceeded

I'm not certain this was caused by the code changes. Do you have any additional insight into this? I might be overlooking a button, but I don't see a means of re-running the build.

@jeffpaul
Copy link
Member

jeffpaul commented Jun 6, 2019

@gthayer might be a permissions issue, I just re-ran the build. 🤞

@gthayer
Copy link
Author

gthayer commented Jun 6, 2019

@jeffpaul - It looks like the build failed again. I'm afraid I don't see what the cause might be. The commit is a fairly simple change to one line, and that file is not referenced in any of the notices in the build script.

I think the test "Push data sync" is failing, which I assume is this? dc99af51500440a672b0aeece0b49d1f/tests/wpacceptance/InternalPushTest.php#L54

@jeffpaul jeffpaul requested a review from dkotter June 6, 2019 13:30
@jeffpaul
Copy link
Member

jeffpaul commented Jun 6, 2019

@adamsilverstein @dkotter as either of you get a chance, could you check that failing test to see if it needs to be updated?

@jeffpaul
Copy link
Member

jeffpaul commented Jun 6, 2019

Resolves #123

@jeffpaul jeffpaul modified the milestones: Future Release, 1.5.0 Jun 6, 2019
@helen helen merged commit 97c29e0 into develop Jul 17, 2019
@helen helen deleted the fix/dt_push_post_args branch July 18, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires reporter feedback to better understand the request. type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dt_push_post_args filters are defined inconsistently.
3 participants