-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify dt_push_post_args
usage
#371
Conversation
@gthayer it looks like the build failed on these changes, mind giving those a review to try and ensure this build passes? |
@jeffpaul - I'm not familiar with the CI setup here, but it looks like there was a timeout error on the build:
I'm not certain this was caused by the code changes. Do you have any additional insight into this? I might be overlooking a button, but I don't see a means of re-running the build. |
@gthayer might be a permissions issue, I just re-ran the build. 🤞 |
@jeffpaul - It looks like the build failed again. I'm afraid I don't see what the cause might be. The commit is a fairly simple change to one line, and that file is not referenced in any of the notices in the build script. I think the test "Push data sync" is failing, which I assume is this? dc99af51500440a672b0aeece0b49d1f/tests/wpacceptance/InternalPushTest.php#L54 |
@adamsilverstein @dkotter as either of you get a chance, could you check that failing test to see if it needs to be updated? |
Resolves #123 |
Unified the usage of
dt_push_post_args
, where External Connections are using 3 variables with the 3rd being the class object, while Internal Connections have 4 variables with the 4th being the class object. Added the$args
value in the 3rd slot and pushed the class object to the 4th value.Fixes: #370