-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return response from distribution request #524
Comments
@armdev17 thanks again for the feedback. If you're able to work on a PR for this, then we can get it through code review and let you know if we have any questions or concerns. |
I'll work on a pull request to resolve this. |
We will try to have some progress on this one in near future. Is this something that will helpful others, have you ever noticed timeouts or other issues with sending updates via external connections? |
@arsendovlatyan I think being able to capture sites that succeeded and failed is useful, whether that happens via the solution noted or in a different manner should be discussed. We're currently working to finish up the v2.0 release, but will come back to this topic when we're assessing what to milestone for the v2.1 release. In the meantime, if you have any other details on the problem and proposed solution then please note that... thanks! |
This feature adds to hooks for dt_subscription_after_post_push and dt_subscriptions_after_post_push to be able to take action after a subscribed post has been pushed and after the entire set of subscriptions have been pushed
I know there has been some work done in a separate PR (#417) however, that PR seemed to be stale. PR #1043 tries to simply add hooks w/ the currently available information. It solves an issue we currently have between I understand this implementation doesn't have all the data If 2.0 work is being done to address hooks for subscriptions feel free to close this PR |
We're using distributor in background and calling \Distributor\Subscriptions\send_notifications directly. As the function doesn't return any value, we're not able to get information about the distributed post. Is it possible to return the response of the request from this function, so we can know whether it was distributed successfully or not ?
https://github.com/10up/distributor/blob/develop/includes/subscriptions.php#L280
The text was updated successfully, but these errors were encountered: