Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return response from distribution request #524

Open
aahovhannisyan opened this issue Feb 14, 2020 · 5 comments · May be fixed by #1043
Open

Return response from distribution request #524

aahovhannisyan opened this issue Feb 14, 2020 · 5 comments · May be fixed by #1043
Assignees
Labels
help wanted type:enhancement New feature or request.

Comments

@aahovhannisyan
Copy link
Contributor

We're using distributor in background and calling \Distributor\Subscriptions\send_notifications directly. As the function doesn't return any value, we're not able to get information about the distributed post. Is it possible to return the response of the request from this function, so we can know whether it was distributed successfully or not ?
https://github.com/10up/distributor/blob/develop/includes/subscriptions.php#L280

@aahovhannisyan aahovhannisyan added the type:enhancement New feature or request. label Feb 14, 2020
@jeffpaul jeffpaul added this to the Future Release milestone Feb 19, 2020
@jeffpaul
Copy link
Member

@armdev17 thanks again for the feedback. If you're able to work on a PR for this, then we can get it through code review and let you know if we have any questions or concerns.

@aahovhannisyan
Copy link
Contributor Author

I'll work on a pull request to resolve this.

@arsendovlatyan
Copy link
Contributor

We will try to have some progress on this one in near future.
@jeffpaul @dinhtungdu you can find my thoughts here NovemBit#18 , your feedback will be very useful for us.

Is this something that will helpful others, have you ever noticed timeouts or other issues with sending updates via external connections?

@jeffpaul
Copy link
Member

@arsendovlatyan I think being able to capture sites that succeeded and failed is useful, whether that happens via the solution noted or in a different manner should be discussed. We're currently working to finish up the v2.0 release, but will come back to this topic when we're assessing what to milestone for the v2.1 release. In the meantime, if you have any other details on the problem and proposed solution then please note that... thanks!

aaronware added a commit to linchpin/distributor that referenced this issue Apr 6, 2023
This feature adds to hooks for dt_subscription_after_post_push and dt_subscriptions_after_post_push to be able to take action after a subscribed post has been pushed and after the entire set of subscriptions have been pushed
@aaronware aaronware linked a pull request Apr 6, 2023 that will close this issue
4 tasks
@aaronware
Copy link

I know there has been some work done in a separate PR (#417) however, that PR seemed to be stale. PR #1043 tries to simply add hooks w/ the currently available information. It solves an issue we currently have between dt_push_post being called vs when a subscription is pushed.

I understand this implementation doesn't have all the data dt_push_post (Network or External) has it does at least allow access to allow developers to interact w/ post subscription.

If 2.0 work is being done to address hooks for subscriptions feel free to close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type:enhancement New feature or request.
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

4 participants