Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used Distributable PostTypes for Check Post Type Permissions via REST API #1246

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

mehul0810
Copy link
Contributor

@mehul0810 mehul0810 commented Jul 13, 2024

Description of the Change

After checking on how to test and verifying the list of post types received for get_post_types() and distributable_post_types() and then did the necessary change to replace functions.

Closes #912

How to test the Change

Access REST API endpoint: /wp-json/wp/v2/distributor/post-types-permissions (Make sure you use block theme like 2024)

Changelog Entry

Fixed - Bug fix

Credits

Props @peterwilsoncc @mehul0810

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mehul0810 mehul0810 requested a review from a team as a code owner July 13, 2024 03:17
@mehul0810 mehul0810 requested review from faisal-alvi and removed request for a team July 13, 2024 03:17
@github-actions github-actions bot added this to the 2.1.0 milestone Jul 13, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Jul 13, 2024
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/TT4

before:
image

after:
image

Ignoring E2E failures assuming they are being addressed in #1248

@jeffpaul jeffpaul merged commit 28e6abc into develop Jul 29, 2024
13 of 18 checks passed
@jeffpaul jeffpaul deleted the fix/912 branch July 29, 2024 16:38
@dkotter dkotter modified the milestones: 2.1.0, 2.0.5 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account for FSE post types in rest endpoints.
5 participants