-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeout on ajax_verify_external_connection #245
Conversation
@dkotter does your work touch this area of the code? If not, then I'm inclined to see if we can resolve the build error and look to land this alongside the performance improvements you've opened for v1.5.0. |
@jeffpaul Nope, the performance changes I've been working on have only touched how we get internal connections, not external. |
@madmax3365 it looks like the build failed on these changes, mind giving those a review to try and ensure this build passes? |
@jeffpaul It seems that problem is in Travis. We have another pull request #262 that failed due to the same reason |
@adamsilverstein @dkotter if either of you have time to review this that would be great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with 100 CPT and this PR handle it very well while couldn't do the same with the current develop
branch. Great work! Here are just some suggestions to make the codebase more maintainable.
includes/classes/ExternalConnections/WordPressExternalConnection.php
Outdated
Show resolved
Hide resolved
includes/classes/ExternalConnections/WordPressExternalConnection.php
Outdated
Show resolved
Hide resolved
@dinhtungdu Applied code changes as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madmax3365 Thanks! I added some comments on your updates :)
Related to #244. We can use these methods to check connections, it gives us a 4x performance boost.