Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests #181

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Fix E2E tests #181

merged 3 commits into from
Oct 10, 2023

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Sep 20, 2023

Description of the Change

PR #180 has upgraded Cypress to 13, but that major release of Cypress contains breaking changes. As a result, E2E tests started failing on develop. PR updates test files to fix failures and also upgrades an npm packages as below:

  • Bump Cypress version from 13.1.0 to 13.2.0
  • Bump @10up/cypress-wp-utils version to 0.2.0
  • Bump @wordpress/env version from 5.6.0 to 8.7.0
  • Bump cypress-mochawesome-reporter from 3.4.0 to 3.6.0

Closes #178

How to test the Change

Make sure PR PASS E2E tests check OR verify E2E tests locally.

Changelog Entry

Fixed - Ensure E2E tests pass.
Changed - Bump Cypress version from 13.1.0 to 13.2.0
Changed - Bump @10up/cypress-wp-utils version to 0.2.0
Changed - Bump @wordpress/env version from 5.6.0 to 8.7.0
Changed - Bump cypress-mochawesome-reporter version from 3.4.0 to 3.6.0

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested review from fabiankaegy and a team as code owners September 20, 2023 10:09
@iamdharmesh iamdharmesh requested review from Sidsector9 and removed request for a team September 20, 2023 10:09
@iamdharmesh iamdharmesh added this to the 1.2.0 milestone Sep 20, 2023
@iamdharmesh iamdharmesh self-assigned this Sep 20, 2023
@Sidsector9
Copy link
Member

@iamdharmesh thanks for working on this. I noticed that tests on trunk are failing, is that expected?

@iamdharmesh
Copy link
Member Author

@Sidsector9 I have checked on failing tests in the WP trunk and it's due to the plugin's issue with WP 6.4 beta (reported #182). We can ignore it in this PR and can proceed with merging this PR to fix the E2E tests in other environments as of now. And the test failure in the WP trunk will be fixed once we fix the reported issue #182.

Thank you.

@jeffpaul jeffpaul merged commit 9b490cc into develop Oct 10, 2023
12 of 13 checks passed
@jeffpaul jeffpaul deleted the upkeep/178 branch October 10, 2023 01:01
@dkotter dkotter modified the milestones: 1.2.0, 1.1.2 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Cypress to version 13
4 participants