-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e/55: Cypress test initial setup #155
Conversation
… e2e/55-default-admin-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sidsector9, running the whole tests on my local using npm run cypress:open
and I got two errors, please check the attached screenshots for more details:
Is able to add IPv4 and IPv6 address without and without label
@dinhtungdu did you manually add "Test IP"? Can you delete it and test? |
@Sidsector9 I'm sorry, that's my bad. After resetting the environment, the test is passing. |
.github/workflows/cypress.yml
Outdated
on: | ||
push: | ||
branches: | ||
- e2e/55-default-admin-settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is passing, but we need to update this run condition before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes absolutely, this is just so that I can ensure things are working well on Github Actions
package.json
Outdated
"dependencies": { | ||
"cypress-file-upload": "^5.0.8" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package should be a dev dependency too.
… e2e/55-default-admin-settings
a09180f
to
8e65278
Compare
…icted-site-access into e2e/55-default-admin-settings
8e65278
to
53f37a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sidsector9 Awesome work! LGTM! 🎉
@Sidsector9 anything additional you want to get into this PR or you good for merge? |
Description of the Change
The following tests focus on the backend settings:
301
,302
and307