Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/updated unit tests #56

Merged
merged 54 commits into from
Mar 27, 2019
Merged

Feature/updated unit tests #56

merged 54 commits into from
Mar 27, 2019

Conversation

petenelson
Copy link
Contributor

No description provided.

@petenelson
initial commit for switching from WP_Mock to core WP tests
014ce5e
@petenelson
added tests for is_ip()
c865f9c
@petenelson
updated tests for is_ip():
c645f85
@petenelson
added test for ip_in_range()
0bba7ff
@petenelson
added test for get_client_ip_address()
8881f3a
@petenelson
updated travis yml
2a52862
@petenelson
added test_activation()
32de4f1
@petenelson
updated travis yml
e650eb2
@petenelson
added test_deactivation()
188c0cd
@petenelson
added multisite config
8770d42
@petenelson
updated travis yml
e5df35d
@petenelson
updated travis yml
b39da6e
@petenelson
refactored tests for activation and deactivation
4b44929
@petenelson
added test_get_options
13c187d
@petenelson
initial work on refactoring restrict_access_check to be testable and …
c870b43 
…the test_restrict_access_not_restricted test
@petenelson
initial work on testing restricted access
331353b
@petenelson
added test for whitelisted IP
d62b129
@petenelson
refactored whitelisted IP tests
73f36f3
@petenelson
added test_restrict_access_show_them_a_page(), fixed a redirect loop …
e750812 
…bug when there are no permalink structures set
@petenelson
updated travis yml
76b7d71
@petenelson
added test_restrict_access_show_them_a_message() and refactored the c…
64e40a6 
…ase for showing a message to return an array
@petenelson
small test updates
4a73929
@petenelson
small test updates
a13c934
@petenelson
moved restriction tests into new folders
b8efedf
@petenelson
initial work on code coverage
a477e16
@petenelson
refactored some tests into separate folders
9b0c8c1
@petenelson
defined plugin root
9ed688e
@petenelson
added is_network() check
079abea
@petenelson
Added test_multisite_restrict_access_not_restricted
4c5511b
@petenelson
added test_multiesite_restrict_access_restricted_default
85cb09e
@petenelson
Copy link
Contributor Author

This covers issue #55

Aside from the new unit tests, the main changes to the plugin code are:

  • Refactored the restrict_access function into a new restrict_access_check function. The new function just performs the checks, and the original calls the new function and performs the redirect or die as-needed.
  • Fixed a bug that caused a redirect loop if there weren't any pretty permalinks set.
  • Added codeCoverage directives where they were needed.
  • Other minor refactoring to allow better testing.

@adamsilverstein
Copy link

This is tremendous @petenelson! Is this ready for merge? do you have time to work on resolving the merge conflict? looks like something small.

@petenelson
Copy link
Contributor Author

Thanks @adamsilverstein, merge conflict has been resolved.

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 6, 2019
@jeffpaul jeffpaul added this to the 7.1.0 milestone Feb 6, 2019
@adamsilverstein adamsilverstein self-assigned this Mar 20, 2019
adamsilverstein
adamsilverstein approved these changes Mar 20, 2019
View reviewed changes
Copy link

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Excellent! Going to do some local testing, then merge.

@adamsilverstein
Copy link

Tests went well, we should update the readme with info about the WP_TESTS_DOMAIN constant since it will disable functionality.

@adamsilverstein adamsilverstein merged commit 966130b into 10up:develop Mar 27, 2019
@adamsilverstein adamsilverstein mentioned this pull request Apr 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@helen helen Awaiting requested review from helen

Assignees

@petenelson petenelson

@adamsilverstein adamsilverstein

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@petenelson @adamsilverstein @jeffpaul