Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document filter for changing default redirect status code #365

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Document filter for changing default redirect status code #365

merged 3 commits into from
Feb 15, 2024

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Feb 15, 2024 •
edited
Loading

Description of the Change

Documentation change:

  • provide example for srm_default_direct_status filter in readme.MD (GitHub default)
  • link to developer docs in readme.txt (WordPress.org default)
  • warn of browser caching for permanent redirects

Closes #364

How to test the Change

N/A Docs change only.

Changelog Entry

Added - Provide example for modifying the default redirect status code
Added - Link to developer docs from WordPress.org

Credits

Props @peterwilsoncc, @jeffpaul, @JosVelasco

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the 2.2.0 milestone Feb 15, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Feb 15, 2024
@dkotter dkotter merged commit 1d7410b into develop Feb 15, 2024
13 checks passed
@dkotter dkotter deleted the docs/364-changing-default-redirect-status branch February 15, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees

@peterwilsoncc peterwilsoncc

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

301 HTTP Status Code by default
2 participants
@peterwilsoncc @dkotter