Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate WP_HTML_Tag_Processor in favor of DOMDocument for assertEqualMarkup #73

Conversation

westonruter
Copy link
Collaborator

@westonruter westonruter changed the title Eliminate WP_HTML_Tag_Processor in favor of DOMDocument for assertMarkupEquals Eliminate WP_HTML_Tag_Processor in favor of DOMDocument for assertMarkupEquals Jun 8, 2023
Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is fixes the tests for me locally, is much simpler and removes the dependency on the WP_HTML_Tag_Processor. All good things!

@westonruter westonruter merged commit 5ae3a5b into feature/enhance-wp-scripts-api-with-a-loading-strategy Jun 8, 2023
@westonruter westonruter deleted the fix/assert-equal-markup branch June 8, 2023 21:12
@westonruter westonruter changed the title Eliminate WP_HTML_Tag_Processor in favor of DOMDocument for assertMarkupEquals Eliminate WP_HTML_Tag_Processor in favor of DOMDocument for assertEqualMarkup Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants