Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kharidian Desert Overhaul #544

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SirFancyBacon
Copy link
Contributor

@SirFancyBacon SirFancyBacon commented Dec 26, 2024

Scope:
Upgrade Kharidian region to better reflect the vanilla visual styles while fixing blending issues, ensuring Winter theme is disregarded within the region as; it clearly wouldn't be snowing there, and general ugliness correction.

Reason:
117 did not have the tools we have not to do proper tile sorting and texturing based on HSL values and locked the sand to a single color, hue and saturation to resolve horrible brightness problems as well as mixed up grass\sand\dirt textures in the desert and on its borders.

Technical notes:

  • Uses a hue adjustment instead of a fixed hue value; Improves visual blending.
  • Cap brightness of grass and sand to avoid "hot spots"; Visual improvement.
  • Use resolver tiles to select grass, dirt, and sand dynamically; reduces visual bugs.
  • Original 117 sand kept in as "KHARID_DESERT_SAND"; is currently overwritten entirely by new sand and serves no purpose; Held for legacy.
  • Winter theme does not impact grass defined in this area by design.
  • Defines a new version of the gravel material without a normal map to correct visual bugs impacting vertical tiles

Comparisons:

Vanilla\Current\Proposed:
image
image
image

image
image
image

image
image
image

image
image
image

image
image
image

image
image
image

image
image
image

image
image
image

@SirFancyBacon SirFancyBacon changed the title Kharidian Desert Overhault Kharidian Desert Overhaul Dec 26, 2024
@SirFancyBacon SirFancyBacon marked this pull request as ready for review December 26, 2024 22:10
[ 3266, 3262, 0, 3269, 3263, 0 ],
[ 3275, 3294, 0, 3275, 3295, 0 ],
[ 3292, 3328, 0, 3300, 3329, 0 ]
[ 3348, 3293, 3415, 3329 ],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these served no logical purpose. another i extended to correct an overworld bug.
Arguably could be renamed to "Mage Training Arena Grass" as short of the one fix that is all it is at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant