-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kharidian Desert Overhaul #544
Open
SirFancyBacon
wants to merge
8
commits into
117HD:master
Choose a base branch
from
SirFancyBacon:jin-christmas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirFancyBacon
commented
Dec 26, 2024
[ 3266, 3262, 0, 3269, 3263, 0 ], | ||
[ 3275, 3294, 0, 3275, 3295, 0 ], | ||
[ 3292, 3328, 0, 3300, 3329, 0 ] | ||
[ 3348, 3293, 3415, 3329 ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these served no logical purpose. another i extended to correct an overworld bug.
Arguably could be renamed to "Mage Training Arena Grass" as short of the one fix that is all it is at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope:
Upgrade Kharidian region to better reflect the vanilla visual styles while fixing blending issues, ensuring Winter theme is disregarded within the region as; it clearly wouldn't be snowing there, and general ugliness correction.
Reason:
117 did not have the tools we have not to do proper tile sorting and texturing based on HSL values and locked the sand to a single color, hue and saturation to resolve horrible brightness problems as well as mixed up grass\sand\dirt textures in the desert and on its borders.
Technical notes:
Comparisons:
Vanilla\Current\Proposed: