Allow custom filename for AssetCache #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #24, allowing custom filenames for
AssetCache
via a callback function taking thekey
andhash
as arguments.Usage:
Might be interesting to explore this to hash the contents instead so the filename is more unique but I think this should cover base cases at the very least.
Additionally, lines 25–27 might be overzealous and could likely be discarded, since the getter does check for length meaning we'd fall back to the default filename. Please edit to your heart's content!