Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BrowserSync Ghost Mode by Default #841

Closed
zachleat opened this issue Jan 3, 2020 · 2 comments
Closed

Disable BrowserSync Ghost Mode by Default #841

zachleat opened this issue Jan 3, 2020 · 2 comments
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement
Milestone
Eleventy 1.0.0

Comments

@zachleat
Copy link
Member

zachleat commented Jan 3, 2020 •
edited
Loading

https://www.browsersync.io/docs/options/#option-ghostMode

As suggested by @clottman in 11ty/eleventy-base-blog#34

I agree it’s a little weird but worth discussion.

Note to use ghostMode: false to disable it all in one fell swoop
@zachleat zachleat added breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. labels Jan 3, 2020
@zachleat zachleat added this to the Next Major Version milestone Jan 3, 2020
@zachleat
Copy link
Member Author

zachleat commented Jan 3, 2020

This repository is now using lodash style issue management for enhancements. This means enhancement issues will now be closed instead of leaving them open.

View the enhancement backlog here. Don’t forget to upvote the top comment with 👍!

@zachleat zachleat closed this as completed Jan 3, 2020
This was referenced Jan 3, 2020
Merged
Closed
@sjml sjml mentioned this issue Aug 4, 2020
Closed
@zachleat zachleat modified the milestones: Planning for Eleventy v1.0.0, Eleventy 1.0.0 Nov 22, 2020
@zachleat zachleat removed the needs-votes A feature request on the backlog that needs upvotes or downvotes. Remove this label when resolved. label Nov 22, 2020
zachleat added a commit that referenced this issue Nov 22, 2020
@zachleat
Fixes #841
7a658a6
@zachleat
Copy link
Member Author

Shipping with 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change This will have to be included with a major version as it breaks backwards compatibility. enhancement
Projects
None yet
Milestone
Eleventy 1.0.0
Development

No branches or pull requests
1 participant
@zachleat